Only compute solid blocks once #3068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Description
SolidBlockMask
previously went through all block states on construction to find all movement-blocking block states. While that doesn't take much time, it adds up as the mask is used in other places, e.g. on every click with a brush. Precalculating the values only once additionally allows us to use the information in other places where we previously called into NMS code through multiple layers of abstraction to check whether a block blocks movement.For example operations using an angle mask can benefit from that.