Skip to content

Fix BatchProcessor ordering in MultiBatchProcessor #3048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

SirYwell
Copy link
Member

Overview

Description

I noticed that the order is based on HashMap, which does not make any guarantees about value iteration order. EnumMap is a better choice as it guarantees iteration order in the natural order of the enum values.

### Submitter Checklist
- [x] Make sure you are opening from a topic branch (**/feature/fix/docs/ branch** (right side)) and not your main branch.
- [x] Ensure that the pull request title represents the desired changelog entry.
- [x] New public fields and methods are annotated with `@since TODO`.
- [x] I read and followed the [contribution guidelines](https://github.com/IntellectualSites/.github/blob/main/CONTRIBUTING.md).

@SirYwell SirYwell requested a review from a team as a code owner December 29, 2024 16:20
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Dec 29, 2024
@dordsor21 dordsor21 requested a review from a team December 30, 2024 13:44
@dordsor21 dordsor21 merged commit a34806c into main Jan 7, 2025
9 checks passed
@dordsor21 dordsor21 deleted the fix/BatchProcessor-ordering branch January 7, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants