Skip to content

fix: take confirm-large from default limit for unlimited, add option to override #2782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix: take confirm-large from default limit for unlimited, add option to override #2782

merged 1 commit into from
Jun 20, 2024

Conversation

dordsor21
Copy link
Member

@dordsor21 dordsor21 marked this pull request as ready for review June 14, 2024 20:40
@dordsor21 dordsor21 requested a review from a team as a code owner June 14, 2024 20:40
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jun 14, 2024
@NotMyFault NotMyFault requested a review from a team June 15, 2024 11:07
@dordsor21 dordsor21 merged commit d69dc97 into main Jun 20, 2024
9 checks passed
@dordsor21 dordsor21 deleted the fix/confirm-large-unlimited branch June 20, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@PierreSchwang PierreSchwang PierreSchwang approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confirm-large does nothing to "unlimited" limit
3 participants
@dordsor21 @NotMyFault @PierreSchwang