feat: improve fawe limits #2773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dordsor21
commented
Jun 9, 2024
| @Switch(name = 'p', desc = "Show any printed output") | ||
| boolean print | ||
| @Switch(name = 'h', desc = "Hide any printed output") | ||
| boolean hide |
There was a problem hiding this comment.
Not having output from this brush is awkward, especially since it only runs the command once, default to showing output
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
# Conflicts: # worldedit-core/src/main/resources/lang/strings.json
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
PierreSchwang
approved these changes
Jun 26, 2024
NotMyFault
approved these changes
Jul 28, 2024
dordsor21
added a commit
that referenced
this pull request
Jul 28, 2024
This reverts commit 6052fc3.
dordsor21
added a commit
that referenced
this pull request
Jul 28, 2024
- add FaweLimit implementations for increasing concurrency levels - allow FaweLimit to perform processing (and forcefully disable as required) to capture [tile] entities - Use `BlockVector3#set(Extent orDefault)` where appropriate to reduce block checks - fixes #2679 - fixes #1874 (cherry picked from commit 6052fc3)
dordsor21
added a commit
that referenced
this pull request
Jul 28, 2024
- cannot remember why I made this change in the first place in #2773 but this fixes edits having "empty middles" - doesn't seem to have broken anything in testing
dordsor21
added a commit
that referenced
this pull request
Sep 14, 2024
- add FaweLimit implementations for increasing concurrency levels - allow FaweLimit to perform processing (and forcefully disable as required) to capture [tile] entities - Use `BlockVector3#set(Extent orDefault)` where appropriate to reduce block checks - fixes #2679 - fixes #1874 (cherry picked from commit 6052fc3)
dordsor21
added a commit
that referenced
this pull request
Sep 14, 2024
- cannot remember why I made this change in the first place in #2773 but this fixes edits having "empty middles" - doesn't seem to have broken anything in testing
dordsor21
added a commit
that referenced
this pull request
Sep 15, 2024
- add FaweLimit implementations for increasing concurrency levels - allow FaweLimit to perform processing (and forcefully disable as required) to capture [tile] entities - Use `BlockVector3#set(Extent orDefault)` where appropriate to reduce block checks - fixes #2679 - fixes #1874 (cherry picked from commit 6052fc3)
dordsor21
added a commit
that referenced
this pull request
Sep 15, 2024
- cannot remember why I made this change in the first place in #2773 but this fixes edits having "empty middles" - doesn't seem to have broken anything in testing
dordsor21
added a commit
that referenced
this pull request
Sep 17, 2024
* feat: improve fawe limits (#2773) - add FaweLimit implementations for increasing concurrency levels - allow FaweLimit to perform processing (and forcefully disable as required) to capture [tile] entities - Use `BlockVector3#set(Extent orDefault)` where appropriate to reduce block checks - fixes #2679 - fixes #1874 (cherry picked from commit 6052fc3) * fix: actually apply a filter if applied from a full region chunk section - cannot remember why I made this change in the first place in #2773 but this fixes edits having "empty middles" - doesn't seem to have broken anything in testing * Reduce limit to always atomic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockVector3#set(Extent orDefault)where appropriate to reduce block checks