Skip to content

fix: extract new config option for deleting disk history on logout #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: extract new config option for deleting disk history on logout #2772

merged 2 commits into from
Jun 26, 2024

Conversation

dordsor21
Copy link
Member

@dordsor21 dordsor21 requested a review from a team as a code owner June 9, 2024 08:17
@github-actions github-actions bot added the Bugfix This PR fixes a bug label Jun 9, 2024
@NotMyFault NotMyFault requested a review from a team June 9, 2024 09:34
PierreSchwang
PierreSchwang approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@PierreSchwang PierreSchwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NotMyFault NotMyFault merged commit 75af797 into main Jun 26, 2024
9 checks passed
@NotMyFault NotMyFault deleted the fix/delete-history-disk-config branch June 26, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@PierreSchwang PierreSchwang PierreSchwang approved these changes

Assignees
No one assigned
Labels
Bugfix This PR fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

delete-on-logout config option also wipes history from the disk
3 participants
@dordsor21 @NotMyFault @PierreSchwang