Skip to content

Drop LD client back down to 2.x.x #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2023
Merged

Drop LD client back down to 2.x.x #29

merged 2 commits into from
Oct 16, 2023

Conversation

KentHawkings
Copy link
Collaborator

@KentHawkings KentHawkings commented Oct 16, 2023 •
edited
Loading

Description

Reverts the ldclient dependency back to 2.1.2. There are two primary reasons for this:

  1. We initially bumped this as we thought it might help fix our issue with feature flags not working. However this workaround should do the trick.
  2. The bump means that zexbox is no longer compatible with tesla (at least until this PR goes in).

@KentHawkings KentHawkings marked this pull request as draft October 16, 2023 12:24
@KentHawkings KentHawkings marked this pull request as ready for review October 16, 2023 12:54
@KentHawkings KentHawkings merged commit 21a3493 into master Oct 16, 2023
@KentHawkings KentHawkings deleted the revert_ld_client_bump branch October 16, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DylanBlakemore DylanBlakemore DylanBlakemore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KentHawkings @DylanBlakemore