Skip to content

ENH: Adding Python example to create mesh and cells #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PranjalSahu
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added area:Core Issues affecting the Core module language:Python Changes to Python examples type:Enhancement Improvement of existing methods or implementation labels May 20, 2022
@PranjalSahu PranjalSahu force-pushed the AddPointsAndEdges branch 2 times, most recently from 15857a0 to 5284f70 Compare May 20, 2022 20:58
@PranjalSahu
Copy link
Collaborator Author

Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example code looks good!

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PranjalSahu awesome, thanks!

Please run black on the code to fix the linting issues.

@PranjalSahu
Copy link
Collaborator Author

I will do it now.

@PranjalSahu
Copy link
Collaborator Author

Added license also.

Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revisit #66 now?

@PranjalSahu
Copy link
Collaborator Author

@dzenanz I can complete that PR quickly.

@dzenanz dzenanz merged commit 88826a6 into InsightSoftwareConsortium:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Core Issues affecting the Core module language:Python Changes to Python examples type:Enhancement Improvement of existing methods or implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants