Skip to content

Use pydata-sphinx-theme #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 23, 2022
Merged

Use pydata-sphinx-theme #378

merged 5 commits into from
May 23, 2022

Conversation

PaulHax
Copy link
Contributor

@PaulHax PaulHax commented May 20, 2022 •
edited
Loading

New skin:
image

closes #323
closes #377

@github-actions github-actions bot added the type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots label May 20, 2022
@thewtex thewtex self-requested a review May 20, 2022 19:33
@PaulHax PaulHax marked this pull request as ready for review May 20, 2022 19:44
@github-actions github-actions bot added area:Documentation Issues affecting the Documentation module type:Data Changes to example data (usually displayed images) labels May 20, 2022
@PaulHax PaulHax force-pushed the pydata-theme branch 2 times, most recently from 31068c4 to d89d4b0 Compare May 20, 2022 21:24
@tbirdso
Copy link
Contributor

tbirdso commented May 22, 2022

@PaulHax The new skin looks great!! There is one docs build failure on CDash, it looks like DownloadExampleHighlighted.png is downloaded in Documentation/Build but referenced in both Documentation/Build and Documentation/Download. Maybe the resource should be downloaded in both folders?

2022-05-20T23:00:23.4712844Z /home/runner/work/bld/ITKEx-build/Documentation/Download/index.rst:22: WARNING: image file not readable: Documentation/Download/DownloadExampleHighlighted.png

@thewtex
Copy link
Member

thewtex commented May 23, 2022

🌮 🌮 💯 !

A rebase on master to resolve conflicts?

@tbirdso
Copy link
Contributor

tbirdso commented May 23, 2022 •
edited
Loading

build-test-cxx failure looks like an issue fetching from data.kitware.com and will likely be resolved on re-run. Will let CI continue for now to get results from build-test-documentation.

tbirdso
tbirdso approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @PaulHax ! CI is green 🟢

Is this ready to be merged?

@PaulHax
Copy link
Contributor Author

PaulHax commented May 23, 2022

Good to go! Thanks for the guidance.

@tbirdso tbirdso merged commit 6ff476a into InsightSoftwareConsortium:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso approved these changes

@thewtex thewtex Awaiting requested review from thewtex

Assignees
No one assigned
Labels
area:Documentation Issues affecting the Documentation module type:Data Changes to example data (usually displayed images) type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: PDF and EPUB links broken Use pydata-sphinx-theme
3 participants
@PaulHax @tbirdso @thewtex