Skip to content

ENH: Add labeler workflow #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jhlegarreta
Copy link
Member

Add labeler workflow so that a GitHub action, triggered when a PR is
opened, automatically labels the PR based on the given rules.

@jhlegarreta
Copy link
Member Author

jhlegarreta commented Sep 29, 2021

Took the freedom to import the relevant labels from the ITK repository:

  • Added some examples-specific labels: Python Notebook, language:C++, language:Python
  • Removed: action:ApplyClangFormat, area:Examples, area:Python wrapping

Additionally, the following labels:

  • Added a type:Nonunit
  • Added a type:Data

Might be worthwhile to be added to ITK as well. I ignore why they were not added back at the time. Let me know what you think.

Add labeler workflow so that a `GitHub` action, triggered when a PR is
opened, automatically labels the PR based on the given rules.

Exclude the `labeler.yaml` from the linter.
@jhlegarreta
Copy link
Member Author

I excluded the labeler.yml file from the linter because the linter would like it to have some heading, which I think is not necessary, and found a duplication for area:Documentation which is not strictly correct since one should operate on commit prefixes and the other one on filenames:
https://github.com/InsightSoftwareConsortium/ITKSphinxExamples/runs/3750344302?check_suite_focus=true#step:7:74

@jhlegarreta
Copy link
Member Author

I guess we will not know if it works properly until it gets merged, much like the one in ITK did.

@dzenanz dzenanz merged commit 3f8d0a2 into InsightSoftwareConsortium:master Sep 30, 2021
@jhlegarreta jhlegarreta deleted the AddLabelerWorkflow branch September 30, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants