Skip to content

feat: Add servers unavailable status on ThreadListView(Header) #1842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feat: Add servers unavailable status on ThreadListView(Header) #1842

wants to merge 4 commits into from
+125 −16

Conversation

Matthieu-dgl
Copy link
Contributor

No description provided.

@Matthieu-dgl Matthieu-dgl self-assigned this Jun 17, 2025
@github-actions GitHub Actions
Copy link

Found 2 unused code occurences

Expand 
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

valentinperignon
valentinperignon requested changes Jun 17, 2025
View reviewed changes
@Matthieu-dgl Matthieu-dgl marked this pull request as draft June 18, 2025 04:07
@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-endpoint-to-monitor-mail-api-health branch from b1fe5e2 to 7f5eab4 Compare June 18, 2025 11:14
PhilippeWeidmann
PhilippeWeidmann reviewed Jun 18, 2025
View reviewed changes
@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-endpoint-to-monitor-mail-api-health branch from ac8b30e to 5276195 Compare June 18, 2025 12:23
PhilippeWeidmann
PhilippeWeidmann reviewed Jun 18, 2025
View reviewed changes
PhilippeWeidmann
PhilippeWeidmann reviewed Jun 18, 2025
View reviewed changes
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need an actor to keep a reference to the task to prevent doing the call too often.
We also don't need to try to do the call if we are not connected.
We'll discuss it live once we know more about what to do with the /ping route.

@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-endpoint-to-monitor-mail-api-health branch 2 times, most recently from faa44e3 to a8933e2 Compare June 23, 2025 04:13
@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-endpoint-to-monitor-mail-api-health branch 3 times, most recently from f4233bb to 4543f1a Compare July 8, 2025 04:36
@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-endpoint-to-monitor-mail-api-health branch 4 times, most recently from 5d6d153 to 958df31 Compare July 28, 2025 06:16
@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-endpoint-to-monitor-mail-api-health branch from 958df31 to 08f6662 Compare July 29, 2025 12:55
@Matthieu-dgl Matthieu-dgl force-pushed the feat/add-endpoint-to-monitor-mail-api-health branch from 08f6662 to 1d82039 Compare July 31, 2025 08:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilippeWeidmann PhilippeWeidmann PhilippeWeidmann left review comments

@valentinperignon valentinperignon valentinperignon requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Matthieu-dgl Matthieu-dgl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Matthieu-dgl @PhilippeWeidmann @valentinperignon