Skip to content

feat(EmojiReaction): Add reaction buttons UI #1814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

valentinperignon
Copy link
Member

No description provided.

@valentinperignon valentinperignon changed the base branch from master to feat/reactions/compute-reactions May 19, 2025 14:28
@valentinperignon valentinperignon force-pushed the feat/reactions/ui/reaction-button branch from 9e8434e to 82b606f Compare May 19, 2025 14:29
Copy link

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

@valentinperignon valentinperignon force-pushed the feat/reactions/compute-reactions branch from b82f54f to 4305e84 Compare May 20, 2025 15:51
@valentinperignon valentinperignon force-pushed the feat/reactions/ui/reaction-button branch from ae3871b to ec125ab Compare May 20, 2025 15:51
@valentinperignon valentinperignon force-pushed the feat/reactions/ui/reaction-button branch from ec125ab to d7881d4 Compare May 21, 2025 07:07
@valentinperignon valentinperignon force-pushed the feat/reactions/ui/reaction-button branch from 300e05d to 74f03c1 Compare May 21, 2025 07:19
@valentinperignon valentinperignon force-pushed the feat/reactions/ui/reaction-button branch from d173bff to 8b4cf23 Compare May 21, 2025 07:30
@valentinperignon valentinperignon marked this pull request as ready for review May 22, 2025 08:44
@valentinperignon valentinperignon force-pushed the feat/reactions/ui/reaction-button branch from 0930565 to 1a4a934 Compare May 22, 2025 12:43
Copy link

@PhilippeWeidmann PhilippeWeidmann merged commit 09a819d into feat/reactions/compute-reactions May 22, 2025
5 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the feat/reactions/ui/reaction-button branch May 22, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants