Skip to content

fix: Disable unwanted drag&drop #1783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lebojo
Copy link
Contributor

@lebojo lebojo commented May 1, 2025

Disable drag & drop for non-movable mails and restricted folders. Prevents users from dragging emails that shouldn't be moved and blocks dropping into disallowed folders to improve UX consistency and prevent unintended actions.

Copy link

github-actions bot commented May 1, 2025

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

@lebojo lebojo force-pushed the fix/disable-drag-and-drop-for-unwanted-folders branch 2 times, most recently from 569f5fb to e1bb8f8 Compare May 5, 2025 11:44
@lebojo lebojo requested a review from PhilippeWeidmann May 5, 2025 11:55
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name isWritable is not very typical. We need to think about an other name

@lebojo lebojo force-pushed the fix/disable-drag-and-drop-for-unwanted-folders branch from 9e38c19 to bf7f912 Compare May 6, 2025 10:05
Copy link

sonarqubecloud bot commented May 6, 2025

@PhilippeWeidmann PhilippeWeidmann merged commit 18c1071 into master May 6, 2025
10 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fix/disable-drag-and-drop-for-unwanted-folders branch May 6, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants