fix: Crash on showing schedule floating panel macOS #1774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a macOS crash when scheduling sends by replacing direct environment access of the mailboxManager with an explicit variable (isMyKSuiteFree) to convey the free status.
- Added an isMyKSuiteFree parameter to various floating panel and button views.
- Replaced mailboxManager access in scheduling-related views with the new variable.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Mail/Views/Thread/SnoozedThreadHeaderView.swift | Added mailboxManager as an environment object and passed its isMyKSuiteFree value. |
| Mail/Views/Thread/Message/MessageScheduleHeaderView.swift | Passed isMyKSuiteFree from mailboxManager to the scheduling modal. |
| Mail/Views/Schedule/SnoozedFloatingPanel.swift | Updated the floating panel modifier to include the isMyKSuiteFree parameter. |
| Mail/Views/Schedule/ScheduleFloatingPanelView.swift | Introduced isMyKSuiteFree as a property and passed it down to the CustomScheduleButton. |
| Mail/Views/Schedule/ScheduleFloatingPanel.swift | Added the isMyKSuiteFree parameter to the modifier and view instantiation. |
| Mail/Views/Schedule/CustomScheduleButton.swift | Replaced usage of mailboxManager with the new isMyKSuiteFree parameter. |
| Mail/Views/New Message/ComposeMessageView.swift | Integrated isMyKSuiteFree into the scheduleFloatingPanel call using mailboxManager values. |
| Mail/Views/Bottom sheets/Actions/ActionsPanelViewModifier.swift | Updated snoozedFloatingPanel to receive the isMyKSuiteFree flag from mailboxManager. |
|
Found 2 unused code occurences Expand |
lebojo
force-pushed
the
fix/macos-app-crash-on-custom-schedule
branch
from
8fda27f to
b7b7b96
Compare
lebojo
changed the title
lebojo
changed the title
lebojo
force-pushed
the
fix/macos-app-crash-on-custom-schedule
branch
from
b7b7b96 to
a271806
Compare
valentinperignon
changed the title
valentinperignon
approved these changes
Apr 29, 2025
valentinperignon
force-pushed
the
fix/macos-app-crash-on-custom-schedule
branch
from
a271806 to
7b30739
Compare
valentinperignon
approved these changes
Apr 29, 2025
|
|
Sentry Issue: MAIL-IOS-3BEY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a crash occurring on macOS when trying to schedule a sending.
The issue was due to platform-specific behavior not being properly handled.
This fix ensures stability across platforms.