fix: Invert sendMail and scheduleDraft Matomo #1772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinperignon
requested review from
lebojo and
Copilot
and removed request for
lebojo
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Matomo event tracking in MailCore to correctly invert the event names for sending mail versus scheduling a draft.
- Inverts the condition in the trackSendMessage function so that "sendMail" is used when draft.scheduleDate is nil, and "scheduleDraft" is used otherwise.
valentinperignon
force-pushed
the
fix/schedule-matomo
branch
from
8d4d730 to
3d1cfb2
Compare
|
|
Found 2 unused code occurences Expand |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.