Skip to content

fix(Snooze): Use thread UID instead of Realm object #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2025
Merged

fix(Snooze): Use thread UID instead of Realm object #1770

merged 2 commits into from
Apr 24, 2025

Conversation

valentinperignon
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link

Found 2 unused code occurences

Expand 
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

@valentinperignon valentinperignon marked this pull request as ready for review April 23, 2025 13:05
@valentinperignon valentinperignon force-pushed the fix/snooze/realm-invalidated branch from 873eca1 to 797f615 Compare April 23, 2025 13:13
@sentry-mobile
Copy link

sentry-mobile bot commented Apr 23, 2025

Sentry Issue: MAIL-IOS-3BDD

@valentinperignon valentinperignon force-pushed the fix/snooze/realm-invalidated branch from 797f615 to 39acd85 Compare April 23, 2025 14:43
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adrien-coye
adrien-coye reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the code, all looks good to me. I'll do a quick session of manual testing tomorrow before approving it. Nice work 👍

adrien-coye
adrien-coye approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took some time to thoroughly test this branch this morning, all good on my side.

@valentinperignon valentinperignon merged commit 9324d75 into master Apr 24, 2025
10 checks passed
@valentinperignon valentinperignon deleted the fix/snooze/realm-invalidated branch April 24, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-coye adrien-coye adrien-coye approved these changes

Assignees

@valentinperignon valentinperignon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinperignon @adrien-coye