Skip to content

fix: Drop current folder if we have too many changes #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2025

Conversation

PhilippeWeidmann
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann commented Apr 16, 2025

How to test

Set Constants.maxChangesCount to a lower number (like 5). Do some changes from webmail or some heavy client.
Check that the folder starts from scratch

Copy link

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

@PhilippeWeidmann PhilippeWeidmann force-pushed the fix/drop-db-on-lost-cursor branch 3 times, most recently from 09343b5 to c44eb16 Compare April 17, 2025 08:48
@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review April 17, 2025 08:55
@PhilippeWeidmann PhilippeWeidmann force-pushed the fix/drop-db-on-lost-cursor branch from c44eb16 to 37a683e Compare April 17, 2025 08:57
@valentinperignon valentinperignon force-pushed the fix/drop-db-on-lost-cursor branch from 37a683e to 2f52b94 Compare April 23, 2025 13:35
Copy link

@valentinperignon valentinperignon merged commit 74f0f20 into master Apr 23, 2025
10 checks passed
@valentinperignon valentinperignon deleted the fix/drop-db-on-lost-cursor branch April 23, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants