Skip to content

fix: Drop realm on migration error in production #1761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

Copy link

Copy link

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.
Also tested the code with multiple accounts on failed migrations.
The execution does interrupt (as long as a debugger is hooked in debug).
Seamless to the user, I'm approving now.

@PhilippeWeidmann PhilippeWeidmann merged commit 1c904f1 into master Apr 15, 2025
11 of 12 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fix/drop-db-on-fail branch April 15, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants