Skip to content

fix: Remove useless properties mailbox #1760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2025

Conversation

PhilippeWeidmann
Copy link
Member

No description provided.

@PhilippeWeidmann PhilippeWeidmann requested review from Ambrdctr and adrien-coye and removed request for Ambrdctr April 14, 2025 12:21
@PhilippeWeidmann PhilippeWeidmann force-pushed the fix/remove-useless-mailbox-properties branch from 0fa5ec8 to 78b52ea Compare April 14, 2025 12:27
Copy link

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

Copy link
Contributor

@adrien-coye adrien-coye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I did some tests migrating accounts and performing some login /logouts.

@PhilippeWeidmann PhilippeWeidmann force-pushed the fix/remove-useless-mailbox-properties branch from 78b52ea to 6432a78 Compare April 14, 2025 13:16
Copy link

@PhilippeWeidmann PhilippeWeidmann merged commit 7ffb67c into master Apr 15, 2025
10 of 11 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the fix/remove-useless-mailbox-properties branch April 15, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants