fix: New actions lists #1756
Open
fix: New actions lists #1756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 2 unused code occurences Expand |
There was a problem hiding this comment.
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
MailCore/Cache/Actions/Action+List.swift:447
- Renaming from 'activeMultiselect' to 'activeMultiSelect' improves consistency; please verify that all references have been updated accordingly.
static let activeMultiSelect = Action(
Mail/Views/Thread List/ThreadListCellContextMenu.swift:156
- [nitpick] Consider renaming 'controlGroupStyleCompactStyle' to a more concise name like 'controlGroupCompactStyle' for improved clarity.
struct controlGroupStyleCompactStyle: ViewModifier {
lebojo
force-pushed
the
fix/context-menu-action-list
branch
from
b5e7b7e to
3eb27e7
Compare
lebojo
force-pushed
the
fix/context-menu-action-list
branch
2 times, most recently
from
d8c94e7 to
3b53c5a
Compare
lebojo
force-pushed
the
fix/context-menu-action-list
branch
2 times, most recently
from
4e6a36b to
97b161a
Compare
lebojo
force-pushed
the
fix/context-menu-action-list
branch
2 times, most recently
from
cd8440a to
eee6a7e
Compare
valentinperignon
force-pushed
the
fix/context-menu-action-list
branch
from
eee6a7e to
237dc66
Compare
valentinperignon
requested changes
May 21, 2025
lebojo
force-pushed
the
fix/context-menu-action-list
branch
4 times, most recently
from
affe3e8 to
ab42e4e
Compare
valentinperignon
requested changes
Jun 2, 2025
Mail/Views/Bottom sheets/Actions/ActionsPanelViewModifier.swift
Outdated
Show resolved
Hide resolved
lebojo
force-pushed
the
fix/context-menu-action-list
branch
3 times, most recently
from
45cb24d to
1be724c
Compare
github-actions
bot
force-pushed
the
fix/context-menu-action-list
branch
from
8bcf223 to
71ccb21
Compare
valentinperignon
force-pushed
the
fix/context-menu-action-list
branch
from
dd8b520 to
71ccb21
Compare
lebojo
force-pushed
the
fix/context-menu-action-list
branch
from
feb6811 to
2136128
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes and consolidating the action handling and view modifiers. The most important changes include the introduction of a new
ActionAlertsViewModifierand a refactorization of the selections of actions process, consolidation of action lists, and updates to various view modifiers to use the new structures.These changes aim to streamline the action handling process, reduce code duplication, and improve maintainability.