feat(Snooze): Unsnooze threads with new message #1754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found 2 unused code occurences Expand |
valentinperignon
force-pushed
the
feat/snooze/unsnooze-new-message
branch
2 times, most recently
from
238747a to
0e1fe71
Compare
valentinperignon
force-pushed
the
feat/snooze/unsnooze-new-message
branch
from
63a4a2c to
696798b
Compare
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
MailCore/Models/Thread.swift:65
- Consider providing a default value (e.g., false) for isLastMessageFromFolderSnoozed to ensure a defined state for new Thread instances not initialized via the custom initializer.
@Persisted public var isLastMessageFromFolderSnoozed: Bool
MailCore/Cache/MailboxManager/MailboxManager.swift:127
- The cast 'as? String?' is redundant; consider using 'as? String' to simplify the code.
let snoozeState = lastMessageFromFolder["snoozeState"] as? String?
696798b to
db9f0d5
Compare
adrien-coye
reviewed
Apr 10, 2025
valentinperignon
force-pushed
the
feat/snooze/unsnooze-new-message
branch
2 times, most recently
from
f53993e to
d74e64a
Compare
valentinperignon
force-pushed
the
feat/snooze/unsnooze-new-message
branch
from
d74e64a to
c90e57e
Compare
|
PhilippeWeidmann
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.