fix: Switch from false to true for the email sent snackbar #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes the issue where the email sent snackbar was not shown by switching the boolean flag from false to true.
- Toggle the flag in the syncDraft call so that the snackbar is displayed
- Minor update in Mail/AppDelegate.swift to support this fix
Comments suppressed due to low confidence (1)
Mail/AppDelegate.swift:82
- Consider adding or updating tests to verify that the snackbar is displayed as expected after this change.
draftManager.syncDraft(mailboxManager: currentMailboxManager, showSnackbar: true)
|
Found 2 unused code occurences Expand |
Ambrdctr
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.