Skip to content

feat: Keep attachment in cache #1740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Conversation

Ambrdctr
Copy link
Contributor

@Ambrdctr Ambrdctr commented Apr 1, 2025

No description provided.

@Ambrdctr Ambrdctr marked this pull request as draft April 1, 2025 10:36
Copy link

github-actions bot commented Apr 1, 2025

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

@Ambrdctr Ambrdctr marked this pull request as ready for review April 1, 2025 11:27
@Ambrdctr Ambrdctr force-pushed the feat/attachment-cache branch 2 times, most recently from 5e3ba19 to 8478e5f Compare April 1, 2025 12:17
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small remarks and we can merge

@Ambrdctr Ambrdctr force-pushed the feat/attachment-cache branch from 5e05201 to 3786ce6 Compare April 3, 2025 06:53
Copy link

sonarqubecloud bot commented Apr 3, 2025

@PhilippeWeidmann PhilippeWeidmann merged commit 501855f into master Apr 3, 2025
10 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the feat/attachment-cache branch April 3, 2025 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants