Skip to content

fix: Contact flickering #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

fix: Contact flickering #1738

merged 2 commits into from
Apr 2, 2025

Conversation

PhilippeWeidmann
Copy link
Member

AvatarViewModel was recreated because the parent view was updated too often + a drop on of the contact cache when moving in the background.
The update was caused by the view not remembering @ModalState. ModalState is now moved in the MainViewState.

Copy link

github-actions bot commented Apr 1, 2025

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

@PhilippeWeidmann PhilippeWeidmann force-pushed the fix/contact-flickering branch from 8dd02d6 to 142eaab Compare April 1, 2025 12:11
Copy link

sonarqubecloud bot commented Apr 1, 2025

@Ambrdctr Ambrdctr merged commit fa45a9f into master Apr 2, 2025
10 checks passed
@Ambrdctr Ambrdctr deleted the fix/contact-flickering branch April 2, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants