Skip to content

feat: Sort autocompletion result #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Conversation

BaptGrv
Copy link
Contributor

@BaptGrv BaptGrv commented Mar 7, 2025

No description provided.

Copy link

github-actions bot commented Mar 7, 2025

Found 2 unused code occurences

Expand
Mail/Views/New Message/ComposeEditor/EditorDesktopToolbarView.swift:29:8: warning: Struct 'EditorDesktopToolbarView' is unused
Mail/Views/Thread List/DraggedEnvelopeView.swift:22:8: warning: Struct 'DraggedEnvelopeView' is unused

@PhilippeWeidmann PhilippeWeidmann self-requested a review March 12, 2025 07:04
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add contacted_times in the with=

@PhilippeWeidmann PhilippeWeidmann marked this pull request as draft March 13, 2025 10:05
@BaptGrv BaptGrv force-pushed the feat/sort-mail-recipients branch from 275499d to 582a9ce Compare March 26, 2025 07:30
@PhilippeWeidmann PhilippeWeidmann self-requested a review March 26, 2025 11:49
@PhilippeWeidmann PhilippeWeidmann marked this pull request as ready for review March 26, 2025 11:49
BaptGrv added 5 commits March 26, 2025 15:06
# Conflicts:
#	MailCore/Models/Contact/Contact.swift
#	MailCore/Models/MergedContact.swift
# Conflicts:
#	Mail/Views/New Message/AutocompletionView.swift
@PhilippeWeidmann PhilippeWeidmann force-pushed the feat/sort-mail-recipients branch from 883cfe4 to 826154e Compare March 26, 2025 14:06
Copy link

@PhilippeWeidmann PhilippeWeidmann merged commit 901e7c0 into master Mar 26, 2025
10 checks passed
@PhilippeWeidmann PhilippeWeidmann deleted the feat/sort-mail-recipients branch March 26, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants