Skip to content

fix: Multiple selection shouldn't navigate #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 14, 2024
Merged

Conversation

PhilippeWeidmann
Copy link
Member

@PhilippeWeidmann PhilippeWeidmann commented Nov 1, 2024

  • Removed tapGesture in favor of Button to better align with what SwiftUI expects.
  • Workaround the navigation issue by disabling the multiple selection in the next run loop. (Basically added a DispatchQueue.main.async 🙃)

Tested in simulator on iOS:

  • 18.1
  • 17.5
  • 16.4
  • 15.5

I'm open to better ideas instead of the workaround.

@PhilippeWeidmann PhilippeWeidmann marked this pull request as draft November 1, 2024 16:13
@PhilippeWeidmann PhilippeWeidmann changed the title fix: Use buttons instead of tapGesture in ThreadListCell fix: Multiple selection shouldn't navigate Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Found 0 unused code occurences

Expand
* No unused code detected.

Copy link
Member

@valentinperignon valentinperignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

Copy link

@valentinperignon valentinperignon merged commit dc6ed92 into master Nov 14, 2024
8 of 9 checks passed
@valentinperignon valentinperignon deleted the fix-selection branch November 14, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants