Desmakers 4505 #338
Closed
Desmakers 4505 #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By creating this pull request you agree to the terms in CONTRIBUTING.md.
https://github.com/Infineon/.github/blob/master/CONTRIBUTING.md
--- DO NOT DELETE ANYTHING ABOVE THIS LINE ---
This pull request includes changes to the
OneWirelibrary to ensure proper return values and improve code readability. The most important changes involve updating method return statements and reordering struct members for consistency.Method Return Value Updates:
libraries/OneWire/src/OneWire.cpp: Updated theresetmethod to return the result ofmImplementation->reset().libraries/OneWire/src/OneWire.cpp: Updated thesearchmethod to return the result ofmImplementation->search(newAddr, search_mode).Struct Member Reordering:
libraries/OneWire/src/util/OneWireConf.h: Reordered themosi_config,miso_config, andsclkout_configstruct members to placeinput_hysteresisbeforeoutput_levelfor consistency. [1] [2]