Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter intermediate links by architecture #2162

Closed
EmptyDogg opened this issue Mar 5, 2025 · 2 comments
Closed

Filter intermediate links by architecture #2162

EmptyDogg opened this issue Mar 5, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@EmptyDogg
Copy link

EmptyDogg commented Mar 5, 2025

Feature Description:
I'd like to be able to filter intermediate links by architecture, similar to the existing "Attempt to filter APKs by CPU architecture if possible" option.

I'm unsure if it would be best to add this functionality to the existing option, or to add a new option to 'filter intermediate links by architecture'. Also, if adding a new option is preferred, I wonder if it would be better to add a single option next to the existing one, which applies to all defined intermediate links, or if adding the option to each intermediate link's definition would be preferred. Any of these options would satisfy my request.

Rationale:
There are some apps which are distributed via sites that are currently best suited to using the HTML source type, where the APK files for different architectures are kept in different locations. This makes the current 'filter APKs by architecture' unusable for these apps.

Example Use Case:
If I go to the list of Crowdsourced App Configs and search for Firefox, all of the listings for the official Firefox options have a separate config for each of the listed architectures, and the less popular apps (Focus & Klar) only have one architecture listed. If there was an option to filter intermediate links by architecture, each of these listings could be reduced to a single config where the user's installation of Obtainium could detect the correct architecture automatically, just like it does with apps where the APKs for all architectures are published together.

@EmptyDogg EmptyDogg added enhancement New feature or request to check Issue has not been reviewed labels Mar 5, 2025
@ImranR98 ImranR98 added TODO Issue to focus on for the next release and removed to check Issue has not been reviewed labels Mar 7, 2025
ImranR98 added a commit that referenced this issue Mar 7, 2025
- Make downloads faster (#580)
- Better sort options for GitHub releases (#2144)
- Enable arch-based auto-filter for intermediate HTML links (#2162)
- GitLab bugfix (#2167)
@ImranR98
Copy link
Owner

ImranR98 commented Mar 7, 2025

@ImranR98 ImranR98 closed this as completed Mar 7, 2025
@ImranR98 ImranR98 removed the TODO Issue to focus on for the next release label Mar 7, 2025
@EmptyDogg
Copy link
Author

EmptyDogg commented Mar 10, 2025

It seems I'm not allowed to reopen a closed issue, which I find a bit strange, it seems to me that reopening this issue would be more appropriate than opening a new issue for this, so I'll just post here anyway, and if it doesn't get any response after a while, I'll escalate it to a new issue.

Anyway... @ImranR98:
Considering that you opted to add a new option which can be applied to the results of each search for 'intermediate links' instead of having it apply to all of them when the final "Attempt to filter APKs by CPU architecture if possible" option is enabled (and I agree with your choice, for the potential efficiency and reliability gains of being able to enable this option only on the list of links that actually needs it) I find it troubling that the option (and its JSON counterpart) is labeled as attempting to filter "APKs" by architecture, not "links", despite being applied to a list of possible intermediate links to follow in order to get the next list of links, not APKs.

Please consider changing the name (and associated JSON key) of this option in the locations where it applies to a list of intermediate links to Attempt to filter links by CPU architecture if possible (and autoLinkFilterByArch) to prevent potential confusion between enabling the option for filtering a specific set of possible intermediate links vs the final set of possible APK links.

Note: I was planning to submit some updates to the Crowdsourced App Configs list to make use of this feature (huge thanks for implementing it!) but felt the naming was confusing and should be changed, and felt that if it does get changed, it would be better to wait till the change happened to submit my app config updates, so they won't need to be updated again for this change.

Thank you!

[Edit: New issue opened. See #2182.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants