[fix] Fix Android build error on react-native 0.67 #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Yeah this looks good to me. I also wanted to clean up the build.gradle, thanks for doing so ❤️ |
|
thanks @IjzerenHein! also appreciate your help to publish new release. |
Kudo
added a commit
to expo/expo
that referenced
this pull request
Feb 17, 2022
# Why try to bump react-native version for sdk 45 # How - [x] upgrade package.json version to `[email protected]` - [x] apply changes from [upgrade helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.67.2) - [x] since 0.67 upgrade to gradle 7 and remove `maven` plugin. ~this pr also migrate packages to use `maven-publish` plugin~ landed in separated pr #16080 - [x] [bare-expo][android] maven plugin from third-party: `react-native-appearance`. ~consider it's archived and deprecated, how to deal with this.~ since we are going to drop sdk 42, i've removed this dependency. - [x] [bare-expo][android] maven plugin from third-party: `react-native-shared-element`. IjzerenHein/react-native-shared-element#90 - [x] [dev-launcher][android] having a `DevLauncherDevSupportManager.kt` for 0.67 and passing null to the new `SurfaceDelegateFactory`. simply to fix the build error first. - [x] [dev-menu][android] it will crash from missing libjsc.so in hermes mode. ~workaround to use jsc mode first~. fix pr: #16099 # Test Plan - bare-expo launch
prakashbask
pushed a commit
to prakashbask/expo
that referenced
this pull request
Mar 16, 2022
# Why try to bump react-native version for sdk 45 # How - [x] upgrade package.json version to `[email protected]` - [x] apply changes from [upgrade helper](https://react-native-community.github.io/upgrade-helper/?from=0.66.4&to=0.67.2) - [x] since 0.67 upgrade to gradle 7 and remove `maven` plugin. ~this pr also migrate packages to use `maven-publish` plugin~ landed in separated pr expo#16080 - [x] [bare-expo][android] maven plugin from third-party: `react-native-appearance`. ~consider it's archived and deprecated, how to deal with this.~ since we are going to drop sdk 42, i've removed this dependency. - [x] [bare-expo][android] maven plugin from third-party: `react-native-shared-element`. IjzerenHein/react-native-shared-element#90 - [x] [dev-launcher][android] having a `DevLauncherDevSupportManager.kt` for 0.67 and passing null to the new `SurfaceDelegateFactory`. simply to fix the build error first. - [x] [dev-menu][android] it will crash from missing libjsc.so in hermes mode. ~workaround to use jsc mode first~. fix pr: expo#16099 # Test Plan - bare-expo launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
react-native 0.67 upgrade to gradle 7 which drop
mavenplugin support.fix #87
How
i think this library does not have to publish as aar format, so i just remove all publish related gradle code. if it's necessary, i can update as the packages' change in the pr: expo/expo#16038
Test Plan