Fix parsing of Basic HTTP Authentication Scheme on the OP side #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- URL-encoding and decoding is not part of the Basic HTTP Authentication Scheme. - The user-id is not allowed to contain colons (`:`). - The password is allowed to contain colons (`:`). Quoting https://www.rfc-editor.org/rfc/rfc7617.html > To receive authorization, the client > [...] > 2. constructs the user-pass by concatenating the user-id, a single > colon (":") character, and the password, > [...] > > Furthermore, a user-id containing a colon character is invalid, as > the first colon in a user-pass string separates user-id and password > from one another; text after the first colon is part of the password. > User-ids containing colons cannot be encoded in user-pass strings. Signed-off-by: Ivan Kanakarakis <[email protected]>
Signed-off-by: Ivan Kanakarakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
:).:).Quoting https://www.rfc-editor.org/rfc/rfc7617.html