docs: add name and description to example SAML2 backend #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider updating the docs as well and/or adding a check for this in code, either here or in pysaml2. |
melanger
changed the title
these attributes are required to generate valid metadata in combination with required_attributes and/or optional_attributes
melanger
changed the title
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These attributes are required to generate valid metadata in combination with required_attributes and/or optional_attributes.
Without these attributes specified (and there is no hint in pysaml2 docs about this either), the generated metadata contains empty
<ns0:ServiceName xml:lang="en" />insideAttributeConsumingService, which is invalid. This was probably the cause of pysaml2#345