Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

'keys' to 'key_conf' #58

Merged
merged 1 commit into from
Dec 18, 2021
Merged

'keys' to 'key_conf' #58

merged 1 commit into from
Dec 18, 2021

Conversation

rohe
Copy link
Contributor

@rohe rohe commented Dec 17, 2021

'keys' attribute in configuration file becomes 'key_conf' attribute in Configuration instance.
The reason for this change comes from using the oidcmsg definitions of Configuration as a subclass of dict.
dict already has a method called keys and this caused a conflict.

Bumped version.

@rohe rohe requested a review from peppelinux December 17, 2021 10:25
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's add a clear message that's it's a btreaking change. Isn't it?

@rohe
Copy link
Contributor Author

rohe commented Dec 17, 2021

Is it a breaking change ?
It doesn't change the format of the configuration file. It's an internal change to how key information is stored in the Configuration class. Now if you deal directly with the Configuration class instance, not using a file or dictionary as the base, or if you're using a dictionary, you've define, where a Configuration instance is expected then you may be in problem.

@peppelinux
Copy link
Member

Great!

@rohe rohe merged commit c6835cc into master Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants