Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Inclusion of oidcservice in oidcrp. #39

Merged
merged 36 commits into from
May 12, 2021
Merged

Inclusion of oidcservice in oidcrp. #39

merged 36 commits into from
May 12, 2021

Conversation

rohe
Copy link
Contributor

@rohe rohe commented May 12, 2021

Too cumbersome to keep 2 packages in synch so we decided to join them into one.
We included oidcservice into OidcRP since the name OidcRP says more about what it's all about than oidcservice.
It's basically a simple merge such that if you have used classes/functions from oidcservice you now should be able to find
them under a similar name where oidcservice is replaced with oidcop.

@rohe rohe requested a review from peppelinux May 12, 2021 07:15
Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve without any doubts ... But CI fails. we should have a release of oidcmsg before oidc-rp release, that's ok.

@rohe
Copy link
Contributor Author

rohe commented May 12, 2021

Yes, the order is OidcMsg, OidcRP and lastly Oidc-op.

@rohe rohe merged commit 6e7c562 into master May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants