Workaround for hyper hangup #98
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyuichi
force-pushed
the
workaround-hyper-hangup
branch
from
a5d90a8 to
cedf91b
Compare
|
It seems that my test in this pull request does not fail in Circle CI even without the patch that removes extra slashes. |
|
We concluded that the root cause of this glitch is the same one discussed in this thread rust-lang/futures-rs#1170. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I described in hyperium/hyper#2306, hyper 0.12 seems have a bug that the event loop hangs up at a very low probability.
This PR introduces an easy (but fairly ungly) workaround for this issue.
Namely, it remotes the first "/" from the query path "/events?" to avoid unnecessary redirection handling.
Currently all GET queries from dockworker should look like "http://localhost:3275//events?" and this PR just removes the redundant slash.
I only removed the slash from the "/events" and "/images/create" APIs because they are the only APIs that return iterators.
I confirmed that the test I added in this PR first failed and after the second commit it succeeded.