BagIt Support - Improve error messages for BagIt handler #8792
Conversation
|
Sample BagIt packages useful for testing: |
|
New error location:
|
There was a problem hiding this comment.
@adaybujeda overall this looks good - my one comment is that there are several places in the tests that seem to match for specific text. I'm usually not a fan of that because if we decide to change the text for whatever reason the test will fail (when it should not) and it's usually sufficient to just confirm that an error happen (or type of error if that can be gotten from sort of enumerated list).
Could you review the tests and see if there are simplifications to be made so that it doesn't have to rely on matching specific texts?
|
Looking into it.... |
abujeda
force-pushed
the
8787-improve-error-messages-bagit-handler
branch
from
c7c974d to
d3a15b4
Compare
|
@scolapasta I have updated the tests that were string matching messages from the Let me know if I missed any other tests. |
mreekie
added
the
NIH OTA: 1.3.1
mreekie
added
pm.GREI-d-1.3.1
What this PR does / why we need it:
Improvements to the error messages for the BagIt file handler. The message location has changed from the top of the page to just underneath the file upload widget.
The message text has been updated following a review from our user testing.
Which issue(s) this PR closes:
Closes #8787
Special notes for your reviewer:
None
Suggestions on how to test this:
As only the error messages has ben updated, we need to enable the
:BagItHandlerEnabledfeature and use invalid BagIt packages.To enable the feature: curl -X PUT -d 'true' http://localhost:8080/api/admin/settings/:BagItHandlerEnabled
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No UI changes. The error messages section where the errors are displayed was already in the system.
Is there a release notes update needed for this change?:
No
Additional documentation:
None