Skip to content

BagIt Support - Improved ignored files for BagIt handler #8755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

abujeda
Copy link
Contributor

@abujeda abujeda commented May 31, 2022

What this PR does / why we need it:
Improved the ignored files for the BagIt file handler. Ignores the control files added automatically by MacOS when creating Zip files.

Which issue(s) this PR closes:

Closes: #8754

Special notes for your reviewer:
N/A

Suggestions on how to test this:
Enable the feature: curl -X PUT -d 'true' http://localhost:8080/api/admin/settings/:BagItHandlerEnabled

Upload a BagIt package as a Zip file created in a MacOS machine.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No

Is there a release notes update needed for this change?:
No

Additional documentation:
N/A

@abujeda
Copy link
Contributor Author

abujeda commented May 31, 2022

Sample BagIt file created in a MacOS environment.
python-computational-workflow-sample.zip

When uploading this file with the :BagItHandlerEnabled set, there should be no files uploaded that start with ._

@abujeda abujeda force-pushed the 8754-bagit-improve-ignored-files branch from 832a30e to eba54ab Compare June 9, 2022 09:43
@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 19.712% when pulling eba54ab on adaybujeda:8754-bagit-improve-ignored-files into daa93ff on IQSS:develop.

@abujeda abujeda force-pushed the 8754-bagit-improve-ignored-files branch from eba54ab to 4e91d1d Compare June 10, 2022 10:28
@kcondon
Copy link
Contributor

kcondon commented Jul 15, 2022

@adaybujeda Would you mind refreshing this branch from develop? The version has changed.

@kcondon kcondon self-assigned this Jul 15, 2022
@abujeda abujeda force-pushed the 8754-bagit-improve-ignored-files branch from 4e91d1d to 0f4e6f1 Compare July 16, 2022 17:06
@abujeda
Copy link
Contributor Author

abujeda commented Jul 16, 2022

Thanks @kcondon, I have rebased from develop. Ready to go.

@kcondon kcondon merged commit 86f69bd into IQSS:develop Jul 18, 2022
@pdurbin pdurbin added this to the 5.12 milestone Jul 25, 2022
@scolapasta scolapasta added HDC: 2 Harvard Data Commons Obj. 2 HDC Harvard Data Commons labels Aug 1, 2022
@mreekie mreekie added the NIH OTA: 1.3.1 3 | 1.3.1 | Support software metadata | 5 prdOwnThis is an item synched from the product planning... label Dec 15, 2022
@mreekie mreekie added pm.GREI-d-1.3.1 NIH, yr1, aim3, task1: Support software metadata pm.GREI-d-1.3.2 NIH, yr1, aim3, task2: R & D phase biomedical workflows support labels Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HDC Harvard Data Commons HDC: 2 Harvard Data Commons Obj. 2 NIH OTA: 1.3.1 3 | 1.3.1 | Support software metadata | 5 prdOwnThis is an item synched from the product planning... pm.GREI-d-1.3.1 NIH, yr1, aim3, task1: Support software metadata pm.GREI-d-1.3.2 NIH, yr1, aim3, task2: R & D phase biomedical workflows support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request/Idea: Improve ignored files for BagIt handler
6 participants