REVIEW fix: CtAnnotation#getValue returns the default value if one exists #2034
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
changed the title
surli
reviewed
Jun 5, 2018
| } | ||
| } | ||
| if (type.isArray() && ret != null && ret.getClass() != type) { |
There was a problem hiding this comment.
Are you sure with the removal of this piece of code? It seems related with the contract with annotation and arrays changed in #1935
There was a problem hiding this comment.
the contract of #1935 is implemented at https://github.com/INRIA/spoon/pull/2034/files#diff-94d063d96db752ab6c7a094f53c75aceR395
do you see a missing test case to specify this?
There was a problem hiding this comment.
OK so you move the creation of the new array. It looks ok then. Merge?
|
I'm done. If you don't see any problem, we can merge.
|
|
Thank you ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2029