Bug fix - Temporary solution to address positional arguments not working #245

[myxie]

Note: These changes were originally raised in #245.

Bug

The positional parameter option currently does not work for Docker and Bash applications. For example, the wsclean_data_local.graph has the Docker-contained wsclean with the following input parameter that is marked as a positional parameter:

However, the graph fails on deployment because the msname property is incorrectly processed as a keyword argument, even thought it is set as "positional" in the UI above. This leads to the -msname property being passed to wsclean as opposed to just the file name:

/bin/bash -c "wsclean -size 512 512 -scale 0.7amin -pol I -spws 0 -niter 10000 -auto-threshold 3 -padding 1 -msname /home/rwb/dlg/workspace/wsclean_data_local12_2024-04-26T12-00-40.261395/MWA-single-timeslot.ms

Root cause

This is due to us populating the cleaned keyargs dictionary with any portkeyargs that have been identified:

daliuge/daliuge-engine/dlg/named_port_utils.py

Lines 294 to 299 in ba97608

	keyargs = {
	arg: appArgs[arg]["value"] for arg in appArgs if not appArgs[arg]["positional"]
	}
	for k, v in portkeyargs.items():
	if v not in [None, ""]:
	keyargs.update({k: v})

The code correctly initialises keyargs by ensuring there are no "positional" arguments; however, if the portkeyargs contains any positional arguments that are also port names (such as in the case of msname), then those arguments will be added to keyargs.

Why is this issue suddenly happening now? portkeyargs is populated by identify_named_ports(). Previously, there was code that commented out adding positional port arguments to the returned portargs variable, which was uncommented in ad3d520:

Solution

As a temporary fix, I've removed the code that was un-commented to return us to previous functionality.
Moving forward, we will want to consider a more holistic fix to update the way we coordinate named ports and keyword arguments.

[myxie]

@awicenec I am now targetting the graph-enabler branch, may you please review this PR?

[myxie]

This has been raised on JIRA: LIU-384