-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EAGLE-1428: Docker image build failure #852
base: master
Are you sure you want to change the base?
Conversation
Reviewer's Guide by SourceryThis pull request refactors the Updated class diagram for RepositoryclassDiagram
class Repository {
+folders()
}
Repository ..> RepositoryFolder : contains
class RepositoryFolder {
+name: string
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @james-strauss-uwa - I've reviewed your changes - here's some feedback:
Overall Comments:
- The change from
for...of
to a indexedfor
loop seems unusual; is there a specific reason for this change?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Changed loop type and added type annotation
Summary by Sourcery
Enhancements: