Skip to content

feat(IAM Policy Management): add access management account settings API #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

feat(IAM Policy Management): add access management account settings API #287

merged 1 commit into from
Mar 21, 2025
+5,077 −2,826

Conversation

kelumkps
Copy link
Member

@kelumkps kelumkps commented Mar 20, 2025 •
edited
Loading

PR summary

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Adds new Access Management Account Settings API (GET and PATCH paths)

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Issue: https://github.ibm.com/IAM/AM-issues/issues/3316

Examples and Integration Test results:

(venv) kelum@kelums-mbp platform-services-python-sdk % python -m pytest examples/test_iam_policy_management_v1_examples.py
=============================================================================================================== test session starts ===============================================================================================================
platform darwin -- Python 3.9.6, pytest-7.4.4, pluggy-1.5.0
rootdir: /Users/kelum/MyDocuments/Projects/platform-services-python-sdk
plugins: cov-4.1.0
collected 33 items                                                                                                                                                                                                                                

examples/test_iam_policy_management_v1_examples.py .................................                                                                                                                                                        [100%]

================================================================================================================ warnings summary =================================================================================================================
venv/lib/python3.9/site-packages/urllib3/__init__.py:35
  /Users/kelum/MyDocuments/Projects/platform-services-python-sdk/venv/lib/python3.9/site-packages/urllib3/__init__.py:35: NotOpenSSLWarning: urllib3 v2 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'. See: https://github.com/urllib3/urllib3/issues/3020
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================================================= 33 passed, 1 warning in 11.01s ==========================================================================================================
(venv) kelum@kelums-mbp platform-services-python-sdk % python -m pytest test/integration/test_iam_policy_management_v1.py 
=============================================================================================================== test session starts ===============================================================================================================
platform darwin -- Python 3.9.6, pytest-7.4.4, pluggy-1.5.0
rootdir: /Users/kelum/MyDocuments/Projects/platform-services-python-sdk
plugins: cov-4.1.0
collected 35 items                                                                                                                                                                                                                                

test/integration/test_iam_policy_management_v1.py ...................................                                                                                                                                                       [100%]

================================================================================================================ warnings summary =================================================================================================================
venv/lib/python3.9/site-packages/urllib3/__init__.py:35
  /Users/kelum/MyDocuments/Projects/platform-services-python-sdk/venv/lib/python3.9/site-packages/urllib3/__init__.py:35: NotOpenSSLWarning: urllib3 v2 only supports OpenSSL 1.1.1+, currently the 'ssl' module is compiled with 'LibreSSL 2.8.3'. See: https://github.com/urllib3/urllib3/issues/3020
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================================================= 35 passed, 1 warning in 15.86s ==========================================================================================================
(venv) kelum@kelums-mbp platform-services-python-sdk %

@CLAassistant
Copy link

CLAassistant commented Mar 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

swcolley
swcolley reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@swcolley swcolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Good job :D

@padamstx padamstx self-assigned this Mar 21, 2025
@padamstx padamstx self-requested a review March 21, 2025 16:07
padamstx
padamstx approved these changes Mar 21, 2025
View reviewed changes
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx padamstx merged commit 7aa264d into main Mar 21, 2025
16 checks passed
@padamstx padamstx deleted the amSettingsSupport branch March 21, 2025 16:25
ibm-devx-sdk pushed a commit that referenced this pull request Mar 21, 2025
@semantic-release-bot
chore(release): 0.63.0 release notes
30ec152 
# [0.63.0](v0.62.0...v0.63.0) (2025-03-21)

### Features

* **IAM Policy Management:** add access management account settings API ([#287](#287)) ([7aa264d](7aa264d))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.63.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swcolley swcolley swcolley left review comments

@padamstx padamstx padamstx approved these changes

Assignees

@padamstx padamstx

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kelumkps @CLAassistant @ibm-devx-sdk @padamstx @swcolley