feat(IAM Policy Management): add access management account settings API #295
Conversation
Signed-off-by: Kelum Senanayake <[email protected]>
|
|
| @@ -65,6 +65,7 @@ describe('IamPolicyManagementV1', () => { | |||
| let exampleAssignmentPolicyId; | |||
| let exampleTargetAccountId; | |||
| let exampleAssignmentETag; | |||
| let exampleAccountSettingsETag; | |||
There was a problem hiding this comment.
If the API definition was outfitted with the link objects to define various inter-operation dependencies, then variables like these exampleXXX variables would be generated automatically and initialized and referenced in the proper places in the generated examples code.
Here is a tutorial video that shows how to do this:
https://secure.video.ibm.com/channel/23887899/playlist/651457/video/133486086
There was a problem hiding this comment.
Hi Phil,
That's a good point, we actually opened this issue last time you pointed this out: https://github.ibm.com/IAM/AM-issues/issues/2197
We'll see if we can get this put in the queue out of the backlog sometime soon.
There was a problem hiding this comment.
If it would help to have a meeting to go over the details, we could work through one or two of the scenarios (i.e. where one operation's outputs are used as input to another operation).
| @@ -148,6 +148,7 @@ describe('IamPolicyManagementV1_integration', () => { | |||
| let testS2STemplateBaseVersion; | |||
| let testS2STemplateVersion; | |||
| let testAssignmentETag; | |||
| let testAccountSettingsETag; | |||
There was a problem hiding this comment.
Same comment re: links from the examples code above applies here.
|
Examples tests are passing: -----------------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------------------------------------------
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-----------------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------------------------------------------
All files | 79.8 | 66 | 87.42 | 81.12 |
iam-policy-management | 79.56 | 66 | 87.34 | 80.88 |
v1.ts | 79.56 | 66 | 87.34 | 80.88 | ...5174,5182,5190-5208,5216-5221,5249-5256,5264,5272-5290,5298-5303,5331-5338,5346,5354-5372,5380-5385,5413-5420,5428,5436-5454,5462-5467
lib | 100 | 100 | 100 | 100 |
common.ts | 100 | 100 | 100 | 100 |
-----------------------|---------|----------|---------|---------|-------------------------------------------------------------------------------------------------------------------------------------------
Test Suites: 1 passed, 1 total
Tests: 34 passed, 34 total
Snapshots: 0 total
Time: 12.782 s, estimated 15 s
Ran all test suites matching /examples\/iam-policy-management.v1.test.js/i. |
…PI : removed the test which checks error responses Signed-off-by: Kelum Senanayake <[email protected]>
|
Integration test passing after removing bad test: Test Suites: 1 passed, 1 total
Tests: 39 passed, 39 total
Snapshots: 0 total
Time: 36.717 s
Ran all test suites matching /test\/integration\/iam-policy-management.v1.test.js/i.
shaunsmacibm@shauns-mbp platform-services-node-sdk % |
# [0.71.0](v0.70.0...v0.71.0) (2025-03-21) ### Features * **IAM Policy Management:** add access management account settings API ([#295](#295)) ([0994fe3](0994fe3))
|
🎉 This PR is included in version 0.71.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…PI (IBM#295) Signed-off-by: Kelum Senanayake <[email protected]>
# [0.71.0](IBM/platform-services-node-sdk@v0.70.0...v0.71.0) (2025-03-21) ### Features * **IAM Policy Management:** add access management account settings API ([IBM#295](IBM#295)) ([0994fe3](IBM@0994fe3))
PR summary
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Adds new Access Management Account Settings API (GET and PATCH paths)
Does this PR introduce a breaking change?
Other information
Issue: https://github.ibm.com/IAM/AM-issues/issues/3316