Skip to content

fix(Global Catalog): fix price field capitalization #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

benbuchanan
Copy link
Contributor

PR summary

Regenerating to fix issue with price field in Price struct capitalization. Also includes addition of deployment_regions field in pricing data, and url field in update object..

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Fixes ability to access price data from get pricing function.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Example tests

Test Suites: 1 passed, 1 total
Tests:       15 passed, 15 total
Snapshots:   0 total
Time:        4.543 s
Ran all test suites matching /examples\/global-catalog.v1.test.js/i.

Integration tests

Test Suites: 19 skipped, 1 passed, 1 of 20 total
Tests:       440 skipped, 27 passed, 467 total
Snapshots:   0 total
Time:        17.092 s
Ran all test suites matching /test\/integration\//i.

@benbuchanan benbuchanan requested a review from padamstx March 13, 2025 15:07
@padamstx padamstx changed the title fix: regenerate to fix price capitalization fix(Global Catalog): fix price field capitalization Mar 13, 2025
@padamstx padamstx self-assigned this Mar 13, 2025
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@padamstx
Copy link
Contributor

@benbuchanan FYI, in order to just directly run jest on a specific test script (rather than rely on regular expression matching against the test labels, which results in skipped tests), you could just do this instead:

npm run jest examples/global-catalog.v1.test.js
npm run jest test/integration/global-catalog.v1.test.js

@padamstx padamstx merged commit 11c745a into IBM:main Mar 13, 2025
7 checks passed
ibm-devx-sdk pushed a commit that referenced this pull request Mar 13, 2025
## [0.69.2](v0.69.1...v0.69.2) (2025-03-13)

### Bug Fixes

* **Global Catalog:** fix price field capitalization ([#293](#293)) ([11c745a](11c745a))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.69.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

benbuchanan pushed a commit to benbuchanan/platform-services-node-sdk that referenced this pull request May 19, 2025
## [0.69.2](IBM/platform-services-node-sdk@v0.69.1...v0.69.2) (2025-03-13)

### Bug Fixes

* **Global Catalog:** fix price field capitalization ([IBM#293](IBM#293)) ([11c745a](IBM@11c745a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants