Skip to content

Commit 11c745a

Browse files
benbuchananbenbuchanan
authored
fix(Global Catalog): fix price field capitalization (#293)
Signed-off-by: Ben Buchanan <[email protected]>
1 parent 20f4980 commit 11c745a

File tree

4 files changed

+1449
-701
lines changed

4 files changed

+1449
-701
lines changed

‎examples/global-catalog.v1.test.js

Lines changed: 43 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@
2121
const GlobalCatalogV1 = require('../dist/global-catalog/v1');
2222
const { readExternalSources, streamToPromise } = require('ibm-cloud-sdk-core');
2323
const authHelper = require('../test/resources/auth-helper.js');
24-
const { CreateCatalogEntryConstants, UpdateCatalogEntryConstants } = require('../dist/global-catalog/v1');
24+
const {
25+
CreateCatalogEntryConstants,
26+
UpdateCatalogEntryConstants,
27+
} = require('../dist/global-catalog/v1');
2528
const { v4: uuidv4 } = require('uuid');
2629

2730
//
@@ -51,6 +54,8 @@ const originalWarn = console.warn;
5154
const consoleLogMock = jest.spyOn(console, 'log');
5255
const consoleWarnMock = jest.spyOn(console, 'warn');
5356

57+
let catalogObject = {};
58+
5459
describe('GlobalCatalogV1', () => {
5560
jest.setTimeout(timeout);
5661

@@ -65,13 +70,11 @@ describe('GlobalCatalogV1', () => {
6570
// Global variables to hold values shared between testcases.
6671
let catalogEntryId;
6772

68-
6973
test('createCatalogEntry request example', async () => {
70-
71-
consoleLogMock.mockImplementation(output => {
74+
consoleLogMock.mockImplementation((output) => {
7275
originalLog(output);
7376
});
74-
consoleWarnMock.mockImplementation(output => {
77+
consoleWarnMock.mockImplementation((output) => {
7578
originalWarn(output);
7679
// when the test fails we need to print out the error message and stop execution right after it
7780
expect(true).toBeFalsy();
@@ -82,7 +85,8 @@ describe('GlobalCatalogV1', () => {
8285
const overviewModelEN = {
8386
display_name: 'Example Web Starter',
8487
description: 'Use the Example service in your applications',
85-
long_description: 'This is a starter that helps you use the Example service within your applications.',
88+
long_description:
89+
'This is a starter that helps you use the Example service within your applications.',
8690
};
8791
const overviewUIModel = {
8892
en: overviewModelEN,
@@ -129,11 +133,10 @@ describe('GlobalCatalogV1', () => {
129133
// end-create_catalog_entry
130134
});
131135
test('getCatalogEntry request example', async () => {
132-
133-
consoleLogMock.mockImplementation(output => {
136+
consoleLogMock.mockImplementation((output) => {
134137
originalLog(output);
135138
});
136-
consoleWarnMock.mockImplementation(output => {
139+
consoleWarnMock.mockImplementation((output) => {
137140
originalWarn(output);
138141
// when the test fails we need to print out the error message and stop execution right after it
139142
expect(true).toBeFalsy();
@@ -151,6 +154,8 @@ describe('GlobalCatalogV1', () => {
151154

152155
try {
153156
const res = await globalCatalogService.getCatalogEntry(params);
157+
catalogObject = res.result;
158+
154159
console.log(JSON.stringify(res.result, null, 2));
155160
} catch (err) {
156161
console.warn(err);
@@ -159,11 +164,10 @@ describe('GlobalCatalogV1', () => {
159164
// end-get_catalog_entry
160165
});
161166
test('updateCatalogEntry request example', async () => {
162-
163-
consoleLogMock.mockImplementation(output => {
167+
consoleLogMock.mockImplementation((output) => {
164168
originalLog(output);
165169
});
166-
consoleWarnMock.mockImplementation(output => {
170+
consoleWarnMock.mockImplementation((output) => {
167171
originalWarn(output);
168172
// when the test fails we need to print out the error message and stop execution right after it
169173
expect(true).toBeFalsy();
@@ -176,7 +180,8 @@ describe('GlobalCatalogV1', () => {
176180
const overviewModelEN = {
177181
display_name: 'Example Web Starter V2',
178182
description: 'Use the Example V2 service in your applications',
179-
long_description: 'This is a starter that helps you use the Example V2 service within your applications.',
183+
long_description:
184+
'This is a starter that helps you use the Example V2 service within your applications.',
180185
};
181186
const overviewUIModel = {
182187
en: overviewModelEN,
@@ -209,6 +214,7 @@ describe('GlobalCatalogV1', () => {
209214
provider: providerModel,
210215
active: true,
211216
metadata: metadataModel,
217+
url: catalogObject.url,
212218
};
213219

214220
try {
@@ -221,11 +227,10 @@ describe('GlobalCatalogV1', () => {
221227
// end-update_catalog_entry
222228
});
223229
test('listCatalogEntries request example', async () => {
224-
225-
consoleLogMock.mockImplementation(output => {
230+
consoleLogMock.mockImplementation((output) => {
226231
originalLog(output);
227232
});
228-
consoleWarnMock.mockImplementation(output => {
233+
consoleWarnMock.mockImplementation((output) => {
229234
originalWarn(output);
230235
// when the test fails we need to print out the error message and stop execution right after it
231236
expect(true).toBeFalsy();
@@ -249,11 +254,10 @@ describe('GlobalCatalogV1', () => {
249254
// end-list_catalog_entries
250255
});
251256
test('getChildObjects request example', async () => {
252-
253-
consoleLogMock.mockImplementation(output => {
257+
consoleLogMock.mockImplementation((output) => {
254258
originalLog(output);
255259
});
256-
consoleWarnMock.mockImplementation(output => {
260+
consoleWarnMock.mockImplementation((output) => {
257261
originalWarn(output);
258262
// when the test fails we need to print out the error message and stop execution right after it
259263
expect(true).toBeFalsy();
@@ -282,11 +286,10 @@ describe('GlobalCatalogV1', () => {
282286
// end-get_child_objects
283287
});
284288
test('restoreCatalogEntry request example', async () => {
285-
286-
consoleLogMock.mockImplementation(output => {
289+
consoleLogMock.mockImplementation((output) => {
287290
originalLog(output);
288291
});
289-
consoleWarnMock.mockImplementation(output => {
292+
consoleWarnMock.mockImplementation((output) => {
290293
originalWarn(output);
291294
// when the test fails we need to print out the error message and stop execution right after it
292295
expect(true).toBeFalsy();
@@ -309,11 +312,10 @@ describe('GlobalCatalogV1', () => {
309312
// end-restore_catalog_entry
310313
});
311314
test('getVisibility request example', async () => {
312-
313-
consoleLogMock.mockImplementation(output => {
315+
consoleLogMock.mockImplementation((output) => {
314316
originalLog(output);
315317
});
316-
consoleWarnMock.mockImplementation(output => {
318+
consoleWarnMock.mockImplementation((output) => {
317319
originalWarn(output);
318320
// when the test fails we need to print out the error message and stop execution right after it
319321
expect(true).toBeFalsy();
@@ -338,11 +340,10 @@ describe('GlobalCatalogV1', () => {
338340
// end-get_visibility
339341
});
340342
test('updateVisibility request example', async () => {
341-
342-
consoleLogMock.mockImplementation(output => {
343+
consoleLogMock.mockImplementation((output) => {
343344
originalLog(output);
344345
});
345-
consoleWarnMock.mockImplementation(output => {
346+
consoleWarnMock.mockImplementation((output) => {
346347
originalWarn(output);
347348
// when the test fails we need to print out the error message and stop execution right after it
348349
expect(true).toBeFalsy();
@@ -366,11 +367,10 @@ describe('GlobalCatalogV1', () => {
366367
// end-update_visibility
367368
});
368369
test('getPricing request example', async () => {
369-
370-
consoleLogMock.mockImplementation(output => {
370+
consoleLogMock.mockImplementation((output) => {
371371
originalLog(output);
372372
});
373-
consoleWarnMock.mockImplementation(output => {
373+
consoleWarnMock.mockImplementation((output) => {
374374
originalWarn(output);
375375
// when the test fails we need to print out the error message and stop execution right after it
376376
expect(true).toBeFalsy();
@@ -395,11 +395,10 @@ describe('GlobalCatalogV1', () => {
395395
// end-get_pricing
396396
});
397397
test('getAuditLogs request example', async () => {
398-
399-
consoleLogMock.mockImplementation(output => {
398+
consoleLogMock.mockImplementation((output) => {
400399
originalLog(output);
401400
});
402-
consoleWarnMock.mockImplementation(output => {
401+
consoleWarnMock.mockImplementation((output) => {
403402
originalWarn(output);
404403
// when the test fails we need to print out the error message and stop execution right after it
405404
expect(true).toBeFalsy();
@@ -426,11 +425,10 @@ describe('GlobalCatalogV1', () => {
426425
// end-get_audit_logs
427426
});
428427
test('uploadArtifact request example', async () => {
429-
430-
consoleLogMock.mockImplementation(output => {
428+
consoleLogMock.mockImplementation((output) => {
431429
originalLog(output);
432430
});
433-
consoleWarnMock.mockImplementation(output => {
431+
consoleWarnMock.mockImplementation((output) => {
434432
originalWarn(output);
435433
// when the test fails we need to print out the error message and stop execution right after it
436434
expect(true).toBeFalsy();
@@ -455,11 +453,10 @@ describe('GlobalCatalogV1', () => {
455453
// end-upload_artifact
456454
});
457455
test('getArtifact request example', async () => {
458-
459-
consoleLogMock.mockImplementation(output => {
456+
consoleLogMock.mockImplementation((output) => {
460457
originalLog(output);
461458
});
462-
consoleWarnMock.mockImplementation(output => {
459+
consoleWarnMock.mockImplementation((output) => {
463460
originalWarn(output);
464461
// when the test fails we need to print out the error message and stop execution right after it
465462
expect(true).toBeFalsy();
@@ -489,11 +486,10 @@ describe('GlobalCatalogV1', () => {
489486
// end-get_artifact
490487
});
491488
test('listArtifacts request example', async () => {
492-
493-
consoleLogMock.mockImplementation(output => {
489+
consoleLogMock.mockImplementation((output) => {
494490
originalLog(output);
495491
});
496-
consoleWarnMock.mockImplementation(output => {
492+
consoleWarnMock.mockImplementation((output) => {
497493
originalWarn(output);
498494
// when the test fails we need to print out the error message and stop execution right after it
499495
expect(true).toBeFalsy();
@@ -518,11 +514,10 @@ describe('GlobalCatalogV1', () => {
518514
// end-list_artifacts
519515
});
520516
test('deleteArtifact request example', async () => {
521-
522-
consoleLogMock.mockImplementation(output => {
517+
consoleLogMock.mockImplementation((output) => {
523518
originalLog(output);
524519
});
525-
consoleWarnMock.mockImplementation(output => {
520+
consoleWarnMock.mockImplementation((output) => {
526521
originalWarn(output);
527522
// when the test fails we need to print out the error message and stop execution right after it
528523
expect(true).toBeFalsy();
@@ -546,11 +541,10 @@ describe('GlobalCatalogV1', () => {
546541
// end-delete_artifact
547542
});
548543
test('deleteCatalogEntry request example', async () => {
549-
550-
consoleLogMock.mockImplementation(output => {
544+
consoleLogMock.mockImplementation((output) => {
551545
originalLog(output);
552546
});
553-
consoleWarnMock.mockImplementation(output => {
547+
consoleWarnMock.mockImplementation((output) => {
554548
originalWarn(output);
555549
// when the test fails we need to print out the error message and stop execution right after it
556550
expect(true).toBeFalsy();

0 commit comments

Comments
 (0)