Skip to content

feat(partner center sell): make tags on deployment creation optional #377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 7, 2025

Conversation

HarasztiaPeter
Copy link
Contributor

@HarasztiaPeter HarasztiaPeter commented Mar 7, 2025

PR summary

For deployments and plans tags should not be required

PR Checklist

Please make sure that your PR fulfills the following requirements:

  • The commit message follows the Angular Commit Message Guidelines.
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Current vs new behavior

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@HarasztiaPeter
Copy link
Contributor Author

HarasztiaPeter commented Mar 7, 2025

Example tests:

Screenshot 2025-03-07 at 14 44 30

@HarasztiaPeter
Copy link
Contributor Author

Integration tests:
Screenshot 2025-03-07 at 14 51 05

@padamstx padamstx self-assigned this Mar 7, 2025
@padamstx padamstx self-requested a review March 7, 2025 16:23
@padamstx padamstx changed the title Fix deployment tags parnercentersellv1 feat(partner center sell): make tags on deployment creation optional Mar 7, 2025
Copy link
Contributor

@padamstx padamstx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@padamstx padamstx merged commit f0cbf75 into main Mar 7, 2025
12 checks passed
@padamstx padamstx deleted the fix-deployment-tags-parnercentersellv1 branch March 7, 2025 16:27
ibm-devx-sdk pushed a commit that referenced this pull request Mar 7, 2025
# [0.78.0](v0.77.1...v0.78.0) (2025-03-07)

### Features

* **partner center sell:** make tags on deployment creation optional ([#377](#377)) ([f0cbf75](f0cbf75))
@ibm-devx-sdk
Copy link

🎉 This PR is included in version 0.78.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants