-
Notifications
You must be signed in to change notification settings - Fork 7
Add MountEITBasedFileShare to mounter interface #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9620187
to
8f80478
Compare
50d10b1
to
098a855
Compare
c335f3f
to
fd9cf9a
Compare
04feb16
to
5e221e9
Compare
Signed-off-by: Sameer Shaikh <[email protected]>
prankulmahajan
commented
Mar 13, 2024
prankulmahajan
commented
Mar 13, 2024
pkg/mountmanager/mount_linux.go
Outdated
} | ||
|
||
if response.StatusCode != http.StatusOK { | ||
return responseBody.ErrorResponse, fmt.Errorf("Response from mount-helper-container -> Exit Status Code: %s ,ResponseCode: %v", responseBody.Error, response.StatusCode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(GoodToHave) Put in common place
prankulmahajan
commented
Mar 13, 2024
sameshai
approved these changes
Apr 18, 2024
sameshai
approved these changes
May 10, 2024
arahamad
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please verify also
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.