Skip to content

Add MountEITBasedFileShare to mounter interface #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 13, 2024
Merged

Add MountEITBasedFileShare to mounter interface #88

merged 23 commits into from
May 13, 2024

Conversation

prankulmahajan
Copy link
Member

No description provided.

@sameshai sameshai force-pushed the eni branch 2 times, most recently from 9620187 to 8f80478 Compare September 11, 2023 04:10
@prankulmahajan prankulmahajan changed the base branch from eni to master October 5, 2023 08:02
@prankulmahajan prankulmahajan force-pushed the eit branch 2 times, most recently from 50d10b1 to 098a855 Compare October 5, 2023 12:50
@prankulmahajan prankulmahajan force-pushed the eit branch 2 times, most recently from c335f3f to fd9cf9a Compare October 18, 2023 10:57
@prankulmahajan prankulmahajan force-pushed the eit branch 2 times, most recently from 04feb16 to 5e221e9 Compare December 6, 2023 11:07
}

if response.StatusCode != http.StatusOK {
return responseBody.ErrorResponse, fmt.Errorf("Response from mount-helper-container -> Exit Status Code: %s ,ResponseCode: %v", responseBody.Error, response.StatusCode)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(GoodToHave) Put in common place

@sameshai sameshai self-requested a review May 10, 2024 05:37
Copy link
Collaborator

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please verify also

@prankulmahajan prankulmahajan merged commit d5df689 into master May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants