Skip to content

Fix e2e COS service instance ID parsing issue #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Fix e2e COS service instance ID parsing issue #122

merged 3 commits into from
Feb 4, 2025

Conversation

sameshai
Copy link
Member

@sameshai sameshai commented Feb 4, 2025

No description provided.

Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
Signed-off-by: Sameer Shaikh <[email protected]>
@sameshai sameshai changed the title Debug e2e COS issue Fix e2e COS service instance ID parsing issue Feb 4, 2025
@sameshai sameshai self-assigned this Feb 4, 2025
Copy link
Collaborator

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide example why it was failing and with your changes how its is passing

@sameshai
Copy link
Member Author

sameshai commented Feb 4, 2025

can you provide example why it was failing and with your changes how its is passing

@arahamad

Failed

5:04:28 + E2ETEST_IC_COS_INSTANCE=crn:v1:staging:public:cloud-object-storage:global:a/8ee7
05:04:28 + ibmcloud ks cluster create vpc-gen2 --name vpc-block-us-south-mzu0mzu4 --zone us-south-1 --vpc-id r134-d1c4df84-5d70-4ef0-a570-d0d9106ae01c --subnet-id 0716-7e86013f-9f97-4bd9-acee-0150b303a12e --version 4.17.12_openshift --cos-instance crn:v1:staging:public:cloud-object-storage:global:a/8ee7 --flavor bx2.4x16 --workers 2
05:04:30 Creating cluster...
05:04:30 FAILED
05:04:30 Cluster was not created. Could not find the specified cloud object storage instance because it does not exist or the API key that is set for this resource group and region has inadequate permissions. For more information, see 'http://ibm.biz/roks_cos_ts'. (E4acb)
05:04:30 
05:04:30 Incident ID: 83aae9db-2d30-483d-9f19-e4c846442ff5
05:04:30 
05:04:30 + rc=1
05:04:30 + [[ 1 -ne 0 ]]
05:04:30 + set +x
05:04:32 + cluster_ok=1
05:04:32 + [[ 1 -ne 0 ]]
05:04:32 + echo 'Error: Cluster creation failed'

success

https://alchemy-containers-jenkins.swg-devops.com/job/Containers-Volumes/job/ibm-vpc-csi-block-e2e/14951/console

working with my branch

+ [[ stage == \p\r\o\d ]]
++ ibmcloud resource service-instance 'Cloud Object Storage-rz' --output json
++ jq -r '.[].id'
+ E2ETEST_IC_COS_INSTANCE=crn:v1:staging:public:cloud-object-storage:global:a/8ee729d7f903db130b00257d91b6977f:a5ecf8b4-36b5-47e4-9f21-caf77ec2868e::
+ ibmcloud ks cluster create vpc-gen2 --name vpc-block-us-south-mji4ndyw --zone us-south-1 --vpc-id r134-d1c4df84-5d70-4ef0-a570-d0d9106ae01c --subnet-id 0716-7e86013f-9f97-4bd9-acee-0150b303a12e --version 4.17.12_openshift --cos-instance crn:v1:staging:public:cloud-object-storage:global:a/8ee729d7f903db130b00257d91b6977f:a5ecf8b4-36b5-47e4-9f21-caf77ec2868e:: --flavor bx2.4x16 --workers 2
Creating cluster...
OK
Cluster created with ID cuh3giv20fgva2fbfe40
+ rc=0
+ [[ 0 -ne 0 ]]

Copy link
Collaborator

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should take COS instance ID as input in the jenkins job

@arahamad arahamad merged commit befec81 into master Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants