Skip to content

Fix for SBD clusters #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 28, 2024
Merged

Fix for SBD clusters #109

merged 3 commits into from
Jun 28, 2024

Conversation

prankulmahajan
Copy link
Member

@prankulmahajan prankulmahajan commented Jun 24, 2024 •
edited
Loading

Added fix:

  • Change cluster name prefix so that it is easier to catch which component created it
  • Use icr.io image for SBD clusters (image is recommended by the network team)

sameshai
sameshai approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@sameshai sameshai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sameshai
sameshai approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@sameshai sameshai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

arahamad
arahamad approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@arahamad arahamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arahamad arahamad merged commit 39e96f1 into master Jun 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameshai sameshai sameshai approved these changes

@arahamad arahamad arahamad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prankulmahajan @sameshai @arahamad