Speed up slow tests, increase db listener test retries #4456
+23
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zac-HD
approved these changes
Jun 29, 2025
| @@ -107,21 +107,20 @@ def test(n): | |||
| test() | |||
|
|
|||
|
|
|||
| def test_does_not_trigger_health_check_when_most_examples_are_small(monkeypatch): | |||
| with deterministic_PRNG(): | |||
There was a problem hiding this comment.
I'm worried about nondeterministic failures here; maybe we can apply @seed(idx) instead with the loop variable?
There was a problem hiding this comment.
done
I don't care too much about nondeterministic failures honestly, I'd actually prefer to use less seeding in our tests in general, so that we don't get silently passing seeded tests when they would have caught a real failure eventually. Of course the flipside is dealing with flakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speeds up some of our slowest tests. Also increases the retries on our db listener tests, since I keep seeing those fail and I'd really like them to stop being flaky. If even this doesn't work then I'll take more drastic measures.