Add PrimitiveProvider.on_observation
#4416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tybug
force-pushed
the
provider-on-observability
branch
from
33094e2 to
b2be76d
Compare
Zac-HD
reviewed
May 28, 2025
|
unrelated note: this line suggests that monkeypatching |
4 tasks
Zac-HD
approved these changes
May 31, 2025
Comment on lines
845
to
856
| return ( | ||
| with_observation_callback(on_observation) | ||
| if ( | ||
| self.settings.backend != "hypothesis" | ||
| # only for lifetime = "test_function" providers (guaranteed | ||
| # by this isinstance check) | ||
| and isinstance(self.provider, PrimitiveProvider) | ||
| # and the provider opted-in to observations | ||
| and self.provider.add_observability_callback | ||
| ) | ||
| else nullcontext() | ||
| ) |
There was a problem hiding this comment.
Seems cleaner as an if-statement and two returns than a ternary expression and one.
There was a problem hiding this comment.
interesting! I disagree, but only very weakly
hypothesis-python/src/hypothesis/internal/conjecture/providers.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm finding this useful as a "post test-case callback" in hypofuzz. I'm hoping to put things like
observation.metadata.data_status: Statusandobservation.metadata.choice_nodesin here, and replace any manual inspection ofConjectureDatafromHypofuzzProvider.