Skip to content

Changes how we treat newtypes #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 27, 2021
Merged

Changes how we treat newtypes #3044

merged 5 commits into from
Jul 27, 2021

Conversation

sobolevn
Copy link
Member

Closes #3043

@sobolevn
Copy link
Member Author

Any tests I should add? I don't know how to test this thing. 🤔

Copy link
Member

@Zac-HD Zac-HD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I don't think we need additional tests for this case, since it only affects prerelease versions of Python which aren't in our CI system.

@Zac-HD Zac-HD merged commit 9d7d515 into master Jul 27, 2021
@Zac-HD Zac-HD deleted the sobolevn-patch-1 branch July 27, 2021 10:34
@sobolevn
Copy link
Member Author

Great! Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6.14.4 test regression with Python 3.10.0b4:
2 participants