Skip to content

Don't notify the lead when a draft is deleted #4158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wes-otf opened this issue Oct 8, 2024 · 1 comment · Fixed by #4159
Closed

Don't notify the lead when a draft is deleted #4158

wes-otf opened this issue Oct 8, 2024 · 1 comment · Fixed by #4159
Assignees
@frjo
Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter

Comments

@wes-otf
Copy link
Contributor

wes-otf commented Oct 8, 2024

When a user deletes a draft, the round/lab lead gets a slack notification that they deleted the draft. We should either remove the notification or we include that it was a draft that was removed.
@wes-otf wes-otf added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels Oct 8, 2024
@frjo
Copy link
Member

frjo commented Oct 8, 2024

I think it can e removed all together. This is something we missed when adding this feature.

@frjo frjo self-assigned this Oct 8, 2024
@frjo frjo mentioned this issue Oct 8, 2024
Merged
1 task
frjo added a commit that referenced this issue Oct 17, 2024
@frjo
Do not send notification when author delete own draft. (#4159)
8beb874 
Fixes #4158
sandeepsajan0 pushed a commit that referenced this issue Oct 18, 2024
@frjo @sandeepsajan0
Do not send notification when author delete own draft. (#4159)
bbaa44b 
Fixes #4158
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frjo frjo

Labels
Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not send notification when author delete own draft. HyphaApp/hypha
2 participants
@frjo @wes-otf